Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DESeq2/Limma #201

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Update DESeq2/Limma #201

merged 7 commits into from
Nov 21, 2023

Conversation

WackerO
Copy link
Collaborator

@WackerO WackerO commented Nov 20, 2023

This pulls the recent DEseq2/Limma updates into diffab (correct naming of output table ID column)

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Sorry, something went wrong.

Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @WackerO,

It looks like this pull-request is has been made against the WackerO/differentialabundance master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the WackerO/differentialabundance dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@WackerO WackerO changed the base branch from master to dev November 20, 2023 13:39
Copy link

github-actions bot commented Nov 20, 2023

nf-core lint overall result: Passed ✅

Posted for pipeline commit 03857ea

+| ✅ 160 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-11-21 08:55:46

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@WackerO WackerO requested a review from pinin4fjords November 20, 2023 14:23
WackerO and others added 3 commits November 21, 2023 08:20

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now- I just removed the 'hopefully'- we should be confident in the fix if you've tested it :-)

@WackerO WackerO merged commit df55a09 into nf-core:dev Nov 21, 2023
@WackerO WackerO deleted the mod_updates branch November 21, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants