Update self_hosted_runner: remove deprecated docker.userEmulation and use containerOptions #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirpedrol
force-pushed
the
self-hosted-runner
branch
from
39ce4e4 to
3ff2b19
Compare
maxulysse
reviewed
Jan 22, 2024
Comment on lines
+18
to
+19
| fixOwnership = true | ||
| runOptions = '--platform=linux/amd64' |
There was a problem hiding this comment.
not sure about keeping fixOwnership
There was a problem hiding this comment.
fixOwnership has to be set to true in the self-hosted runners to avoid an error like touch: .command.trace: Permission denied
|
@mirpedrol do you still plan to finish this? |
|
I think this can be merged, if someone could review 🙏 |
mashehu
approved these changes
May 21, 2024
jfy133
approved these changes
May 21, 2024
|
Ok approved but unable to merge from my phone... @mirpedrol does it give you the option to do so? |
|
Thank you!! |
|
The branch was not up to date 😄 I will merge it once all tests pass! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications to match nf-core/tools#2673 and fix the tests there.The previous PR won't be merged. But
userEmulationis deprecated, so we should remove it.Also remove the preceding
docker.as all options are inside the docker scope.