Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #220 and docs #221

Merged
merged 7 commits into from
Jan 27, 2023
Merged

issue #220 and docs #221

merged 7 commits into from
Jan 27, 2023

Conversation

ssnn-airr
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/airrflow branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Dec 21, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 274f2f2

+| ✅ 158 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in airrflow.nf: Add all file path parameters for the pipeline to the list below
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-01-27 12:00:43

ggabernet
ggabernet previously approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small typo

docs/output.md Outdated Show resolved Hide resolved
@ggabernet ggabernet marked this pull request as ready for review January 27, 2023 11:49
@ggabernet
Copy link
Member

@nf-core-bot fix linting

@ggabernet ggabernet changed the base branch from airrflow to dev January 27, 2023 11:53
@ggabernet ggabernet dismissed their stale review January 27, 2023 11:53

The base branch was changed.

@ggabernet ggabernet changed the base branch from dev to airrflow January 27, 2023 11:53
@ggabernet
Copy link
Member

@nf-core-bot fix linting

@ggabernet ggabernet merged commit 6ff0986 into nf-core:airrflow Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggabernet ggabernet ggabernet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssnn-airr @ggabernet