-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: php 8 support #43
Conversation
Use next expectExceptionMessageMatches
Symfony changed it configuration exception messages when updating to 5.0, so I had to modify a test. I dropped PHP 7.3 support because nexylan/slack#70 did the same. The |
@ndench Thanks! Can you allow me edition on this PR so I can take a look and finish it? |
No problem @soullivaneuh. I've invited you to my fork as a maintainer, feel free to make any changes necessary. I'm happy to help with anything you need as well. |
@ndench Thanks, but by allowing edition, I meant simply this: https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork 😉 |
Unfortunately allowing edits from maintainers appears to only work if the fork is created from a user account. However I created this fork from an organisation account so that checkbox is not available for me. See https://github.community/t/how-can-we-enable-allow-edits-from-maintainers-by-default/2847/6 I do not see the checkbox shown in the docs link: Feel free to edit as a maintainer, or even create a separate branch and pull in my commits if you like. |
@soullivaneuh I got the test passing. The We can solve these by:
|
Hello, Thanks for giving some time on it! 👍 Looks goot to me. |
Just copied the nexylan/slack#70 pull request.