Merge branch fix/argument-parsing into master #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make future development easier
Also fix kwargs log message logging args
I'm not sure why this fixed what was broken but broke it in a different way too
Fixes "TypeError: Keyword-only arguments must be of type str.", caused by "WARNING - Argument got an instance of a type, not a type itself: 'str'. Inspect as if it was its rawtype, <class 'str'>"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation needs updating, then this should be ready to go.
magicpreventing the entire module from loading, instead of just soft-failing some media functionalityCloses #29