Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Firebase hosting deploys on releases #66

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

collinjackson
Copy link
Collaborator

@collinjackson collinjackson commented Nov 25, 2024

Instead of deploying on merge, deploy on release

Fixes #65

Copy link

Visit the preview URL for this PR (updated for commit 9f89ecf):

https://nexus-cli--pr66-collinjackson-ci-dep-sfroepxq.web.app

(expires Mon, 02 Dec 2024 23:32:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 815ec4c632754f56eccfacfc0919559f5a85a0f1

Copy link
Contributor

@stupidmelon stupidmelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@collinjackson collinjackson merged commit e7aaeb2 into main Nov 25, 2024
3 checks passed
@collinjackson collinjackson deleted the collinjackson/ci-deploy branch November 25, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI should deploy to web hosting on releases rather than merges to main
2 participants