Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CLI analytics fix #101

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix: CLI analytics fix #101

merged 2 commits into from
Dec 9, 2024

Conversation

dprats
Copy link
Collaborator

@dprats dprats commented Dec 9, 2024

the CLI was not properly sending analytics event.

There were two issues:

  1. depending on the websocket string a different firebase key is used, this had the wrong key <--- main issue
  2. analytics_api_keyfunction returned empty string in debug mode <--- minor issue

@dprats dprats marked this pull request as ready for review December 9, 2024 23:38
Copy link

github-actions bot commented Dec 9, 2024

Visit the preview URL for this PR (updated for commit edf394b):

https://nexus-cli--pr101-dprats-cli-analytics-mv32kjqf.web.app

(expires Mon, 16 Dec 2024 23:48:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 815ec4c632754f56eccfacfc0919559f5a85a0f1

Copy link
Collaborator

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the debug assertions versions, the idea is to not send analytics events if you're making code changes locally.

@dprats dprats merged commit cfacdc1 into main Dec 9, 2024
3 checks passed
@256-bytie 256-bytie mentioned this pull request Dec 11, 2024
@sahabitukur01 sahabitukur01 mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants