Fix type assertion for primitive type #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Dec 5, 2024
Comment on lines
30
to
36
| static Type wrapTypeIfPrimitive(Type type) { | ||
| Class<?> clazz = primitiveWrapperTypeMap.get(type); | ||
| if (clazz != null) { | ||
| return clazz; | ||
| } | ||
| return type; | ||
| } |
There was a problem hiding this comment.
Can make the map value type a Type too and do:
Suggested change
| static Type wrapTypeIfPrimitive(Type type) { | |
| Class<?> clazz = primitiveWrapperTypeMap.get(type); | |
| if (clazz != null) { | |
| return clazz; | |
| } | |
| return type; | |
| } | |
| static Type wrapTypeIfPrimitive(Type type) { | |
| primitiveWrapperTypeMap.getOrDefault(type, type); | |
| } |
But it's pedantic. Could also just bury the switch in here which may be cleaner.
nexus-sdk/src/main/java/io/nexusrpc/handler/ReflectionUtil.java
Outdated
Show resolved
Hide resolved
cretz
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix type assertion for primitive type since we can't rely on a strict equality in that case.