Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make headers case insensitive #21

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Make headers case insensitive #21

merged 2 commits into from
Nov 28, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Headers should be case insensitive in Nexus. Taking the same approach as the Java standard library by using a TreeMap<>(String.CASE_INSENSITIVE_ORDER)

bergundy
bergundy approved these changes Nov 27, 2024
View reviewed changes
Copy link

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanna add a test?

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 1d7da53 into nexus-rpc:main Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @bergundy