Allow spaces in BEAST annotations #1610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spaces can be included in discrete states during BEAST runs, even if they aren't proper according to NEXUS specs. I've added a space to the regexes for comments, strings in comments, and sets in comments.
jameshadfield
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Thanks for the reproducible example and the fix! Importing nexus trees is rarely done within the group and so this code is rather ancient at this point. We should really do a better job of parsing Nexus trees but without regularly using them ourselves it's not trivial. Would you mind adding an entry to the changelog here?
watronfire
added a commit
to watronfire/augur
that referenced
this pull request
Aug 29, 2024
|
Yeah, glad to help out! Let me know if that changelog message is alright? |
jameshadfield
pushed a commit
that referenced
this pull request
Sep 2, 2024
|
Thanks Nate - I merged in the changes here via #1615 in order to resolve some merge conflicts. We typically make an augur release every week or so, so it shouldn't be too long before your changes are in the release version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spaces can be included in discrete states reconstructed by BEAST, even if they aren't proper according to NEXUS specs.
Description of proposed changes
I've added a space to the regexes for comments, strings in comments, and sets in comments.
Related issue(s)
Resolves: #1609
Checklist