Clarify missing column messages #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous text "Ignoring it" seemed contradictory when it appeared
directly before an error:
WARNING: Column 'QC_rare_mutations' does not exist in the metadata file. Ignoring it.
ERROR: Query contains a column that does not exist in metadata.
The goal is to show the name of the missing column in the error message.
Something like this would be ideal:
ERROR: Query contains a column 'invalid' that does not exist in metadata
However, UndefinedVariableError does not expose the column name apart
from being in the error message text. Showing the entire message text is
slightly redundant, but seems better than parsing the column name out of
message text that's subject to change.
victorlin
force-pushed
the
victorlin/clarify-missing-column-messages
branch
from
eec6b05 to
03e2b69
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1604 +/- ##
=======================================
Coverage 71.02% 71.02%
=======================================
Files 79 79
Lines 8256 8256
Branches 2003 2003
=======================================
Hits 5864 5864
Misses 2101 2101
Partials 291 291 ☔ View full report in Codecov by Sentry. |
genehack
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See commit messages and linked issue
Related issue(s)
Closes #1592
Checklist