-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
augur {read,write}-file #1562
augur {read,write}-file #1562
Conversation
Add commands to read and write files using Augur's conventions. This allows external programs to do i/o like Augur by piping from/to `augur read-file` or `augur write-file`. In some simple testing, the overhead of passing text i/o thru Python vs. not is minimal for our use cases and worth the cost of consistent compression and newline handling. I'll be using this to allow SQLite to read/write files like Augur.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1562 +/- ##
=======================================
Coverage 70.22% 70.22%
=======================================
Files 74 76 +2
Lines 7952 7987 +35
Branches 1945 1947 +2
=======================================
+ Hits 5584 5609 +25
- Misses 2082 2092 +10
Partials 286 286 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no tests?
Ha… yeah… I'm mostly a "tests optional" sort of person naturally. I like integration tests and unit tests for tricky or brittle behaviour, but am not a test maximalist. I've seen way too many large test suites made mostly of useless tests. But, I'll adhere to project/team expectations if Augur/we are "tests for new additions"! |
Fair enough. |
Add commands to read and write files using Augur's conventions. This allows external programs to do i/o like Augur by piping from/to
augur read-file
oraugur write-file
. In some simple testing, the overhead of passing text i/o thru Python vs. not is minimal for our use cases and worth the cost of consistent compression and newline handling.I'll be using this to allow SQLite to read/write files like Augur.
Checklist