Issue 614 ParaGridIO #685
Merged
Issue 614 ParaGridIO #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timspainNERSC
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParaGridO static data
Fixes #614 (partially)
Change Description
Moved the maps between netCDF concepts and
ModelArrayequivalents toconstinstance variables that are initialized as part of the ctor.Moved the static maps from file names to netCDF files and current time indices to a singleton-like function. Also combined the maps, to ensure they remain consistent.
Added the
Finalizerclass to to whatstd::atexitdoes, except at our convenience, rather than executable clean-up. This includes a new test for the new class. This change is the same as that contained in PR #683Test Description
Added a test for the new
Finalizerclass.The
ParaGrid_teststill passes, this mainly tests the parts that pass through toParaGridIO.