Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible modules #456

Closed
wants to merge 53 commits into from
Closed

Flexible modules #456

wants to merge 53 commits into from

Conversation

timspainNERSC
Copy link
Collaborator

@timspainNERSC timspainNERSC commented Dec 5, 2023 •
edited
Loading

Flexible Modules

Fixes #439

To make the modules easier to use, simplify the process of adding a new implementation. This also involves organizing the source and header files rather more neatly.

Test

If all the tests that use modules (which is the majority) still pass, then all is working.

Documentation Impact

Added modules.rst do docs.

@timspainNERSC
Copy the albedo module source files, add the config file.
7e93a15
@timspainNERSC
Move the extant Module files to ref versions. Delete header.hpp.
960a90e
@timspainNERSC
Remove unneeded features from the config file.
fcfe318
@timspainNERSC
A script to create the module files. Module header file.
db88822
@timspainNERSC
Use a string dictionsry to look up values.
9ab53c0
@timspainNERSC
Add default implementation to the example module.cfg.
b60ba10
@timspainNERSC
Remove quotes from the descriptions in the module config file.
6ec3b76
@timspainNERSC
Module source file.
57aadc3
@timspainNERSC
Move module_builder to the new scripts directory.
2310a4f
@timspainNERSC
Set the location of the module_builder script.
d6bf604
@timspainNERSC
Break the module_builder strings into a separate python module.
6c00c8a
@timspainNERSC
Break the module script into a header and a source script.
33d5788
@timspainNERSC
Write the Module header to a path that is not the module directory.
64e9b7f
@timspainNERSC
Correct the header file path.
0bc7e3b
@timspainNERSC
Ignore the generated module files.
ae8a0cf
@timspainNERSC
Add a sensible default for the header path to the config parser.
b2fba41
@timspainNERSC
Untangle header names, paths, directories.
a24f6ff
@timspainNERSC
Add note of the mdoule the source file describes.
66aeb76
@timspainNERSC
Run the script to generate the module files at CMake config time.
f602df2
@timspainNERSC
Correct script typos in module builder python script.
1a20d8d
@timspainNERSC
Rename the reference files.
70594f4
@timspainNERSC
Copy the MU17 albedo source to the ice albedo module dir.
1bc3cb2
@timspainNERSC
Remove the albedo sources from the general module directories.
445d293
@timspainNERSC
Assign the sources to the correct list.
d7e28c9
@timspainNERSC
Use the module-internal include sub-directory.
1831623
@timspainNERSC
Remove the reference files used in development.
eba57c8
@timspainNERSC
Convert the atmosphere boundary module to be generated at config time.
13f4c13
@timspainNERSC
Include the atmosphere boundary module configuration.
8b2bcfe
@timspainNERSC
Convert the flux calculation module to be generated at config time.
9eaace1
@timspainNERSC
Convert the ice ocean flux module to be generated at config time.
5d40873
@timspainNERSC timspainNERSC self-assigned this Dec 5, 2023
@timspainNERSC timspainNERSC added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 5, 2023
@timspainNERSC timspainNERSC added this to the 2 Integration tests milestone Dec 5, 2023
timspainNERSC and others added 11 commits December 6, 2023 07:21
@timspainNERSC
Add the (missed) diag output module config file.
fa7b9c6
@timspainNERSC
Convert the freezing point module to be generated at config time.
a521f86
@timspainNERSC
Convert the dynamics module to be generated at config time.
ff12544
@timspainNERSC
Convert the structure module to be generated at config time.
2965f44
@timspainNERSC
Manually revert the changes in the albedo impl source to match develop.
0a01a0e
@timspainNERSC
Further minimize the differences in the albedo source files.
f7451ee
@timspainNERSC
Delete the generated module headers from the repo.
0bd121f
@timspainNERSC
Add module documentation up to when I got thinking.
2a69a84
@timspainNERSC
Use the descriptive module name rather than the interface class.
008d073
@timspainNERSC
Merge branch 'feat_flexiblemodules_library' of [email protected]:nextsim…
830eefc 
…hub/nextsimdg.git into flexiblemodules_library
@timspainNERSC
Merge branch 'develop' into flexiblemodules_library
b369b9e
@timspainNERSC
Copy link
Collaborator Author

Replaced by #458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timspainNERSC timspainNERSC

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
neXtSIM_DG overview
Status: Done
Milestone
2 Integration tests
Development

Successfully merging this pull request may close these issues.
1 participant
@timspainNERSC