-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mermaid improvements #59
Conversation
Today I am thankful for you Phil 😄 |
just today? |
Thanksgiving 😉 |
For the record, stuff I wanted to do and haven't figured out yet:
In both cases it's because the connector lines in the SVG are semantically unconnected to the node elements. So it's impossible to use CSS selectors alone to control stuff like hover colours 😞 Both are pretty low priority though and I won't be that sad if they never happen. Moving to The styling of this PR, and the action buttons can be ported to the Nextflow HTML DAG export if we want. |
I think I might be able to get the exported mermaid SVG to use the Nextflow greens too 🤔 If I use the mermaid built-in theming with the backup colours, then still override those in CSS. I think that might work. I'll give it a go later. |
It worked! Exported SVGs now also with custom styling 🎉 I think that this is functionally complete now and ready for review / merge. |
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
The HTML export gets a bit meta, but hopefully the code makes some sense. Let me know if you want me to clean it up at all (eg. splitting into separate files etc).
Usage / colour schemes:
CleanShot.2024-11-28.at.16.26.16.mp4
Exported SVG:

Exported HTML:
DAG-BISMARK-demo.html.zip
Exported mermaid markdown: