Fix hash when CmdEvalParam as output #5517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging canceled.
|
e <[email protected]> x test Signed-off-by: jorgee <[email protected]>
jorgee
force-pushed
the
5470-pipeline-uses-cached-process-despite-edited-eval-script
branch
from
40ecdc4 to
d605b2b
Compare
bentsherman
added
the
cache-breaking
…edited-eval-script
|
This alter the assumption the task is idempotent. The task hash should only rely on the inputs not on the outputs |
|
I see the point it could be considered as part of the execution script, but still in principle it should not be needed to re-run the task |
|
Considering that eval is a shorthand for export an output env var in the script, it is essentially part of the script and therefore part of the task identity. I think it is possible to evaluate the task outputs without "resolving" or "collecting" them, before computing the task hash. Then you can see if any output evals were declared and include them as if they were part of the script |
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
5a93547 to
27345a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5470
Adds the CmdEvalParams in the task outputs as a key to compute the hash