-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example of dynamic directive with input file #4545
Conversation
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There are some other real-world examples in this talk: Would be awesome to have something like this to tune resources. |
@christopher-hakkaart for your consideration. It would be good to have an example of setting the memory based on the task inputs, but ideally would be something that is proven to work in the wild. Instead of using Even something like this could be better: // allocate 1 GB for every million reads, up to 32 GB
memory { meta.num_reads / 1_000_000 * 1.GB } |
5a93547
to
27345a6
Compare
Signed-off-by: Ben Sherman <[email protected]>
@christopher-hakkaart can you give this one a review when you have a chance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions.
Co-authored-by: Chris Hakkaart <[email protected]> Signed-off-by: Ben Sherman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the language. The 1e9 notation could be removed or a note could be added to explain. It's not blocking for me.
Signed-off-by: Ben Sherman <[email protected]>
See #4493 (comment)
I don't really like this particular example because it is probably an anti-pattern, i.e. many tools are designed to stream the input data so that they don't have to load entire datasets in memory. But I want to explicitly show that input files can also be used to configure directives.