Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for include_dir #248

Merged
merged 6 commits into from
Dec 25, 2024
Merged

add support for include_dir #248

merged 6 commits into from
Dec 25, 2024

Conversation

sunshowers
Copy link
Member

Also switch to cargo-sync-rdme, since that can handle the required cfg_attr format in the readme better.

Definitely nicer than having a bunch of scripts lying around.
This is exactly the readme generator I feel like I wanted.
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 86.68942% with 39 lines in your changes missing coverage. Please review.

Project coverage is 86.39%. Comparing base (598ca0f) to head (af1b67a).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/data_source.rs 91.07% 19 Missing ⚠️
src/lib.rs 33.33% 12 Missing ⚠️
src/runner.rs 86.88% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   89.49%   86.39%   -3.10%     
==========================================
  Files           4        4              
  Lines         276      463     +187     
==========================================
+ Hits          247      400     +153     
- Misses         29       63      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunshowers sunshowers force-pushed the include-dir branch 3 times, most recently from 7a5a69f to e45ca41 Compare December 24, 2024 09:01
I wanted to publish a crate to crates.io containing a bunch of files with test
vectors that can be reused, and then use it within datatest-stable. To address
this use case, add `include_dir` as an optional dependency.

See the documentation for more.
@sunshowers sunshowers force-pushed the include-dir branch 8 times, most recently from 42c1f79 to 6dc4266 Compare December 25, 2024 00:51
A breaking change, but I think bringing Windows in line with Unix is valuable.

Also fix up other path-related documentation, and add tests for everything.
Coverage information suggested that recursive files weren't covered.
@sunshowers sunshowers merged commit 631c248 into main Dec 25, 2024
9 checks passed
@sunshowers sunshowers deleted the include-dir branch December 25, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant