Following logic #307
Draft
Following logic #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hweihwang
force-pushed
the
poc-whiteboard-recording-server
branch
3 times, most recently
from
f42593c to
86d2680
Compare
juliusknorr
reviewed
Dec 12, 2024
| @@ -151,6 +152,14 @@ export class Portal { | |||
| case BroadcastType.MouseLocation: | |||
| this.collab.updateCursor(decoded.payload) | |||
| break | |||
| case BroadcastType.ViewportUpdate: | |||
| this.collab.updateCollaboratorViewport( | |||
| decoded.payload.userId, | |||
There was a problem hiding this comment.
Just an idea, we could also pass the viewport size to the backend to record depending on the screens size of the user?
hweihwang
force-pushed
the
poc-whiteboard-recording-server
branch
from
86d2680 to
4837c3c
Compare
Signed-off-by: Hoang Pham <[email protected]>
hweihwang
force-pushed
the
poc-whiteboard-recording-server
branch
from
4837c3c to
0c4db45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.