Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user_sql for Nextcloud 30, add optional feature for deleted users #198

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

ApolloLV
Copy link

We tested our modifications of the source code of user_sql (based on the fork https://github.com/rotdrop/user_sql).
In our testing we found that it still works reliably with newer Nextcloud versions (27+), and as such we would request that the compatibility of the app is updated to indicate it works for NC25-NC30.
The code has been brought up-to-date with NC30 requirements.
We also added an optional feature to the plugin that prevents issues if users that have shared files with other users are deleted in the SQL database (or marked as disabled), as the existing shared files will have issues due to uncertain ownership in newer Nextcloud versions.

@syzop
Copy link

syzop commented Nov 2, 2024

I'm just a user here. We also upgraded to NC 30.0.1 just now. Have not applied this patch (yet).

@ApolloLV I'm curious about the placeholder_users feature that you introduced in this PR. You mention without this there are "issues due to uncertain ownership". I suppose this fixes something if the user was not actively deleted from within Nextcloud user management or via the occ tool... but removed/disabled in the SQL table? We make that "mistake" too sometimes.
What are the symptoms that this causes? And, is this only an issue for shared folders from deleted users? Or is it an issue for like.. any file that a user (that is now deleted) ever created on any share?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants