Always cache the complete user record. #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: the callback which tweaks the result is not part of the cache key and differes between calls to getUsers(). So either the cache-key would have to code the callback or we simply cache the complete user record, regardless of the callback. Signed-off-by: Claus-Justus Heine <[email protected]>
rotdrop
force-pushed
the
bugfix/convert-cache-array-to-user-model
branch
from
d4970ce to
cfe7fc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: the callback which tweaks the result is not part of the cache
key and differes between calls to getUsers(). So either the cache-key
would have to code the callback or we simply cache the complete user
record, regardless of the callback.
See also the issue #168