Add global scale (gss) support #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
force-pushed
the
enh/noid/gss
branch
from
a9354a2 to
bb583fe
Compare
juliusknorr
reviewed
Dec 20, 2024
julien-nc
force-pushed
the
enh/noid/gss
branch
from
ab92df4 to
d5fee2b
Compare
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/gss
branch
from
d5fee2b to
4bfbeea
Compare
juliusknorr
reviewed
Jan 14, 2025
| @@ -509,6 +513,9 @@ public function code(string $state = '', string $code = '', string $scope = '', | |||
| $this->userSession->completeLogin($user, ['loginName' => $user->getUID(), 'password' => '']); | |||
| $this->userSession->createSessionToken($this->request, $user->getUID(), $user->getUID()); | |||
| $this->userSession->createRememberMeToken($user); | |||
| // TODO server should/could be refactored so we don't need to manually create the user session and dispatch the login-related events | |||
There was a problem hiding this comment.
Can you file an issue in server and reference that? Helps to keep track of other cases or considerations around that.
There was a problem hiding this comment.
Issue filed: nextcloud/server#50194
juliusknorr
approved these changes
Jan 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds global scale support in user_oidc.
This requires nextcloud/globalsiteselector#168
LoginController::singleLogoutServiceto get the provider ID from the GSS logout JWT tokenQuestions/doubts:
LoginController::singleLogoutServicewe try to get the OIDC login token from the session to optionally pass it as a GET parameter to the "end session endpoint" of the OIDC provider. If the session has died on the GSS master, this won't work. We will pass an empty login token. How bad is this?