Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix key registration #323

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Fix key registration #323

merged 1 commit into from
Feb 17, 2023

Conversation

zevlee
Copy link
Contributor

@zevlee zevlee commented Dec 27, 2022

Fixes #233
Signed-off-by: Zev Lee [email protected]

@zevlee
Copy link
Contributor Author

zevlee commented Dec 27, 2022

Let me know if there are any changes I need to make.

ChristophWurst
ChristophWurst reviewed Dec 27, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing missing is bumping the version in info.xml. Change

twofactor_webauthn/appinfo/info.xml

Line 7 in 9c60f87

<version>1.1.0-alpha.0</version>
from .0 to .1

lib/Migration/Version010000Date20221227080000.php Outdated Show resolved Hide resolved
@zevlee
Copy link
Contributor Author

zevlee commented Dec 27, 2022

The only thing missing is bumping the version in info.xml. Change

twofactor_webauthn/appinfo/info.xml

Line 7 in 9c60f87

<version>1.1.0-alpha.0</version>

from .0 to .1

Did you want the line to read

<version>1.1.1-alpha.0</version>

or

<version>1.1.0-alpha.1</version>

@ChristophWurst
Copy link
Member

The second one :)

ChristophWurst
ChristophWurst approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@zevlee zevlee marked this pull request as ready for review December 27, 2022 14:00
@zevlee
Copy link
Contributor Author

zevlee commented Dec 27, 2022

It looks like there are some workflows that need to be run before this PR can be merged. Is there anything I need to do on my end?

ChristophWurst
ChristophWurst reviewed Dec 28, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick

When you amend your commit, change the commit message from Fix key registration to fix(database schema): Fix public key column size

Ref https://www.conventionalcommits.org/en/v1.0.0/

lib/Migration/Version010000Date20221227080000.php Outdated Show resolved Hide resolved
@ChristophWurst
Copy link
Member

/backport to stable1.0

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Dec 28, 2022
@zevlee
Copy link
Contributor Author

zevlee commented Dec 28, 2022

I changed the commit message as you requested.

@zevlee
Copy link
Contributor Author

zevlee commented Dec 29, 2022

My apologies, it seems that I forgot to add a blank line before the footer of the commit message. It should be fixed now.

@zevlee
Copy link
Contributor Author

zevlee commented Dec 29, 2022

Not sure why the commit message check is failing. Perhaps the scope must be limited to a single word? i.e. fix(database): Fix public key column size

@st3iny st3iny added bug Something isn't working 4. to release Ready to be released and/or waiting for tests to finish labels Jan 3, 2023
@st3iny st3iny added this to the 1.1.0 milestone Jan 3, 2023
@st3iny st3iny modified the milestones: 1.1.0, 1.2.0 Feb 17, 2023
@zevlee @st3iny
fix(database): Fix public key column size
56b9427 
Fixes #233

Signed-off-by: Zev Lee <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny enabled auto-merge February 17, 2023 12:32
@st3iny
Copy link
Member

st3iny commented Feb 17, 2023

/backport to stable1.1

@st3iny st3iny merged commit 357ea27 into nextcloud:main Feb 17, 2023
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 17, 2023
Closed
1 task
@st3iny
Copy link
Member

st3iny commented Feb 17, 2023

/backport to stable1.1

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 17, 2023
Merged
1 task
@zevlee zevlee deleted the fix-key-registration branch February 17, 2023 22:54
@zevlee zevlee mentioned this pull request Feb 18, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny st3iny approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request A backport was requested for this pull request bug Something isn't working
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

adding Solokey 2 >> Data too long for column 'public_key_credential_id' at row 1 at <<closure>>
3 participants
@zevlee @ChristophWurst @st3iny