Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] chore: v8.0.0 #1343

Merged
merged 1 commit into from
Apr 25, 2023
Merged

[stable26] chore: v8.0.0 #1343

merged 1 commit into from
Apr 25, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Mar 30, 2023

This was overlooked for the 26 release.

@ChristophWurst ChristophWurst self-assigned this Mar 30, 2023
@ChristophWurst ChristophWurst changed the title chore: v8.0.0 [stable26] chore: v8.0.0 Mar 30, 2023
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny st3iny disabled auto-merge March 30, 2023 13:27
@st3iny
Copy link
Member

st3iny commented Mar 30, 2023

There actually is a bug with the icon and theming. It is white on a white background. Perhaps, we should include it as it should be the same fix as in the other twofactor apps?

grafik

PS: It works on dark mode. We have to invert the icon for light mode.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@st3iny
Copy link
Member

st3iny commented Mar 30, 2023

Fix at #1347 (needs backport)

@ChristophWurst ChristophWurst requested a review from st3iny April 25, 2023 06:33
Signed-off-by: Christoph Wurst <[email protected]>
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@ChristophWurst ChristophWurst merged commit 7d5bc09 into stable26 Apr 25, 2023
@ChristophWurst ChristophWurst deleted the chore/v8-stable26 branch April 25, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants