-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Increase line width to 80 characters #6520
Conversation
Signed-off-by: Julius Knorr <[email protected]>
Hmm I think talk has already slightly decreased that, cc @Antreesy |
Talks seems to be using https://github.com/nextcloud/spreed/blob/81c8bfca584c3cbb1d8aa4a716a2f19148bb7059/src/assets/variables.scss#L13 (which ends up at 750px with 15px font size), 80ch end up being 734px in text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sgtm then!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Just a note to consider: width may vary a bit depending on a font. so for OpenDyslexic 80ch is ~780px, for default on Win11 ~650px |
I propose to backport this small change. |
📝 Summary
After discussion with designers we wanted to slightly increase the line width of text documents. This is basically the same width as talk uses now for messages which is 80 character width.
Browser support for the ch unit seems sufficient: https://caniuse.com/ch-unit
🖼️ Screenshots
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)