Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] feat: add labels to textarea elements in translate modal #5319

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 29, 2024

Backport of PR #5234

@backportbot backportbot bot added enhancement New feature or request 3. to review labels Jan 29, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.2 milestone Jan 29, 2024
@blizzz blizzz mentioned this pull request Jan 29, 2024
1 task
@emoral435
Copy link

/compile amend/

@emoral435
Copy link

Not to familiar with the text app, so if everything looks good after compiling, and after the freezes, this is perfect! Thank you @luka-nextcloud for the support for accessibility on the website 😊

@juliusknorr
Copy link
Member

We can drop the compile commit here before merging as we have automated that part (for the stable28 branch and up) in text as a proof of concept. It will happen after the merge.

@emoral435 emoral435 force-pushed the backport/5234/stable28 branch from f1da10a to 1c47c4d Compare January 29, 2024 14:25
@emoral435
Copy link

That's actually so cool! Is that a process that we would be able to move to the main sever repo as well 👀 haha

@juliusknorr juliusknorr merged commit d4fbc91 into stable28 Feb 1, 2024
102 of 104 checks passed
@juliusknorr juliusknorr deleted the backport/5234/stable28 branch February 1, 2024 11:17
@skjnldsv skjnldsv mentioned this pull request Feb 14, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants