ci: Add workflow to update node dist files on main #4749

juliusknorr · 2023-08-30T17:37:51Z

Adapting nextcloud/server#39674 for the text app to give it a test run on this branch

Remove compile check

cypress · 2023-08-30T18:00:16Z

3 failed and 2 flaky tests on run #12035 ↗︎

3	141	18	0	2

Details:

ci: Add workflow to update node dist files on main
Project: Text	Commit: `e676d6fe73`
Status: Failed	Duration: 04:47 💡
Started: Sep 6, 2023 6:09 AM	Ended: Sep 6, 2023 6:14 AM

cypress/e2e/attachments.spec.js • 3 failed tests

View Output Video

Test		Artifacts
Test all attachment insertion methods > test if attachment folder is moved with the markdown file		`Output` `Screenshots`
Test all attachment insertion methods > test if attachment folder is copied when copying a markdown file		`Output` `Screenshots`
Test all attachment insertion methods > [share] check everything behaves correctly on the share target user side		`Output` `Screenshots`

files.spec.js • 1 flaky test

View Output Video

Test		Artifacts
Text and server mimetypes > handle markdown with richtext editor		`Output` `Screenshots`

propfind.spec.js • 1 flaky test

View Output Video

Test		Artifacts
Text PROPFIND extension > with workspaces enabled > always adds rich workspace property		`Output` `Screenshots`

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

juliusknorr · 2023-08-30T18:00:41Z

I was fearing some endless loop, but it seems that the git operation by default uses GITHUB_TOKEN which would block any follow up workflow triggered by that push. Meaning CI wouldn't run for the main branch on the compile commit, but i think that is fine since it runs on the previous and next one.

https://docs.github.com/en/actions/security-guides/automatic-token-authentication

max-nextcloud · 2023-08-31T04:03:36Z

CI wouldn't run for the main branch on the compile commit, but i think that is fine since it runs on the previous and next one.

Yes. For me that's even a plus as it will save a considerable amount of CI time.

max-nextcloud · 2023-08-31T04:04:55Z

This looks very interesting - I'm all for trying it out.

I have some follow up questions / ideas:

Is there any reason we cannot use this on stable27 and maybe older?
Could we maybe drop this at some point for master and only have js assets in stable branches?

.github/workflows/update-node-dist.yml

juliusknorr · 2023-08-31T06:00:31Z

Is there any reason we cannot use this on stable27 and maybe older?

Not from my perspective, maybe @skjnldsv had one as the original author of it in the server draft nextcloud/server#39674?

Could we maybe drop this at some point for master and only have js assets in stable branches?

Not until we build during release as there are also nightly packages built from master/main for the server release.

juliusknorr · 2023-08-31T06:11:45Z

Also improved the concurrency block to work with pushes as head_ref is only there for prs

max-nextcloud

One small change - other than that looks good to me.

.github/workflows/update-node-dist.yml

skjnldsv · 2023-08-31T07:13:07Z

Nice! Haven't found the time to keep looking deeper for nextcloud/server#39674
Glad it was caught and of any help 🚀

I don't see why that would be of any issue.
There could be a race condition if for any reason a releaser starts a release right after merge and before the dist files gets updated, but I think that would not be an issue if we just wait a bit :)

.gitignore

max-nextcloud · 2023-09-04T15:04:23Z

.github/workflows/node.yml

+      - name: Check webpack build changes
+        run: |
+          bash -c "[[ \"`git status --porcelain `\" ]] || (echo 'Do NOT commit changes in js/ as those will be built automatically once merged' && exit 1)"
+
+      - name: Show changes on failure
+        if: failure()
+        run: |
+          git status
+          git --no-pager diff
+          exit 1 # make it red to grab attention
+


I don't think this does what you think it does.

git status --porcelain will not find anything as no compilation was run yet.

I see two alternatives:

git diff {name of base branch} js and then fail if it has some output

use the github mechanism to run tasks on changed files in js. (Maybe even in a separate task)

Yes indeed. I moved to a separate workflow and used https://github.com/tj-actions/changed-files which uses the API instead of a local git clone to keep the action simple.

max-nextcloud

🚀

Signed-off-by: Julius Härtl <[email protected]> fix: Check build changes Signed-off-by: Julius Härtl <[email protected]> fix: use CYPRESS_INSTALL_BINARY Signed-off-by: Julius Härtl <[email protected]> fix: ref for push Signed-off-by: Julius Härtl <[email protected]> ci(node): Block merge if js/ was changed Signed-off-by: Julius Härtl <[email protected]> tmp: remove test branch to see if node check works Signed-off-by: Julius Härtl <[email protected]>

juliusknorr added 2. developing technical debt labels Aug 30, 2023

juliusknorr added this to the Nextcloud 28 milestone Aug 30, 2023

max-nextcloud reviewed Aug 31, 2023

View reviewed changes

.github/workflows/update-node-dist.yml Outdated Show resolved Hide resolved

.github/workflows/update-node-dist.yml Outdated Show resolved Hide resolved

.github/workflows/update-node-dist.yml Show resolved Hide resolved

max-nextcloud approved these changes Aug 31, 2023

View reviewed changes

.github/workflows/update-node-dist.yml Show resolved Hide resolved

skjnldsv reviewed Aug 31, 2023

View reviewed changes

.gitignore Show resolved Hide resolved

juliusknorr force-pushed the ci/node-dist-workflow branch 3 times, most recently from 5b72f29 to 6677f9a Compare September 4, 2023 14:51

juliusknorr marked this pull request as ready for review September 4, 2023 14:52

juliusknorr added 3. to review and removed 2. developing labels Sep 4, 2023

juliusknorr requested review from mejo- and skjnldsv September 4, 2023 14:53

max-nextcloud reviewed Sep 4, 2023

View reviewed changes

juliusknorr force-pushed the ci/node-dist-workflow branch 2 times, most recently from b7a2188 to e676d6f Compare September 6, 2023 06:04

max-nextcloud approved these changes Sep 6, 2023

View reviewed changes

juliusknorr force-pushed the ci/node-dist-workflow branch from 29d27e0 to 9dcd2aa Compare September 6, 2023 06:33

juliusknorr merged commit f766606 into main Sep 6, 2023

juliusknorr deleted the ci/node-dist-workflow branch September 6, 2023 06:36

skjnldsv mentioned this pull request Oct 12, 2023

ci: Add workflow to update node dist files on master nextcloud/viewer#1982

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Add workflow to update node dist files on main #4749

ci: Add workflow to update node dist files on main #4749

juliusknorr commented Aug 30, 2023 •

edited

Loading

cypress bot commented Aug 30, 2023 •

edited

Loading

juliusknorr commented Aug 30, 2023

max-nextcloud commented Aug 31, 2023

max-nextcloud commented Aug 31, 2023

juliusknorr commented Aug 31, 2023

juliusknorr commented Aug 31, 2023

max-nextcloud left a comment

skjnldsv commented Aug 31, 2023

max-nextcloud Sep 4, 2023

juliusknorr Sep 6, 2023

max-nextcloud left a comment

ci: Add workflow to update node dist files on main #4749

ci: Add workflow to update node dist files on main #4749

Conversation

juliusknorr commented Aug 30, 2023 • edited Loading

cypress bot commented Aug 30, 2023 • edited Loading

3 failed and 2 flaky tests on run #12035 ↗︎

juliusknorr commented Aug 30, 2023

max-nextcloud commented Aug 31, 2023

max-nextcloud commented Aug 31, 2023

juliusknorr commented Aug 31, 2023

juliusknorr commented Aug 31, 2023

max-nextcloud left a comment

Choose a reason for hiding this comment

skjnldsv commented Aug 31, 2023

max-nextcloud Sep 4, 2023

Choose a reason for hiding this comment

juliusknorr Sep 6, 2023

Choose a reason for hiding this comment

max-nextcloud left a comment

Choose a reason for hiding this comment

juliusknorr commented Aug 30, 2023 •

edited

Loading

cypress bot commented Aug 30, 2023 •

edited

Loading