-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/duplicated load of yjs #4542
Conversation
Passing run #11562 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
db21029
to
9661d6f
Compare
Small comments, but the general approach looks good :) Haven't tested yet though |
9661d6f
to
e37da6f
Compare
@luka-nextcloud I just had a brief look at this - you marked three conversations with julius as resolved but only one of them seems to be addressed (the timeout). I don't understand why you resolved the other ones. When you resolve a conversation without changes to the code - could you add a brief comment explaining why? That would make it easier to understand what is going on. Thanks! ❤️ |
e37da6f
to
e80e8b1
Compare
@max-nextcloud All of the comments are resolved now. |
e80e8b1
to
584ad58
Compare
Signed-off-by: Luka Trovic <[email protected]>
584ad58
to
94eca01
Compare
/compile |
Signed-off-by: nextcloud-command <[email protected]>
I still have this error in my browser console after upgrade to 27.1.0 final. |
As far as i can tell this has not been backported to 27. I'll trigger a backport - not sure if we want to backport but we can discuss that in the backport PR. |
/backport 94eca01 to stable27 |
📝 Summary
Reset value of
window['__ $YJS$ __']
before Editor component is mounted to avoid console errorYjs was already imported.
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)