Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clickable zone of task list checkbox #4312

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Conversation

luka-nextcloud
Copy link
Contributor

๐Ÿ“ Summary

๐Ÿ–ผ๏ธ Screenshots

๐Ÿš๏ธ Before ๐Ÿก After
B A

๐Ÿšง TODO

  • ...

๐Ÿ Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@luka-nextcloud luka-nextcloud self-assigned this Jun 19, 2023
@cypress
Copy link

cypress bot commented Jun 19, 2023

2 flaky tests on run #10300 โ†—๏ธŽ

0 147 1 0 Flakiness 2

Details:

fix: clickable zone of task list checkbox
Project: Text Commit: 84896305e4
Status: Passed Duration: 03:20 ๐Ÿ’ก
Started: Jun 20, 2023 6:57 AM Ended: Jun 20, 2023 7:00 AM
Flakinessย  nodes/HardBreak.spec.js โ€ข 1 flaky test

View Output Video

Test Artifacts
Hard break support > Can create hard breaks with shift+enter Output Screenshots
Flakinessย  api/UsersApi.spec.js โ€ข 1 flaky test

View Output Video

Test Artifacts
The user mention API > fetches users with valid session Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Jun 19, 2023
@juliusknorr juliusknorr added this to the Nextcloud 28 milestone Jun 19, 2023
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@juliusknorr juliusknorr force-pushed the bugfix/checkbox-click branch from 91cb4d1 to 9dcb688 Compare June 20, 2023 06:41
@juliusknorr
Copy link
Member

/compile

Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr juliusknorr merged commit 5c9f626 into main Jun 20, 2023
@juliusknorr juliusknorr deleted the bugfix/checkbox-click branch June 20, 2023 07:06
@juliusknorr
Copy link
Member

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mejo-
Copy link
Member

mejo- commented Jun 20, 2023

/backport 9dcb688 to stable27

@mejo-
Copy link
Member

mejo- commented Jun 20, 2023

/backport 9dcb688 to stable26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox click target is way to small
4 participants