Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] Fix editing image description fails if enter isn't pressed #4114

Merged
merged 1 commit into from
May 4, 2023

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented May 3, 2023

📝 Summary

Backport of #4071

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@luka-nextcloud luka-nextcloud changed the title Fix editing image description fails if enter isn't pressed [Backport] Fix editing image description fails if enter isn't pressed May 3, 2023
@cypress
Copy link

cypress bot commented May 3, 2023

3 flaky tests on run #9650 ↗︎

0 142 1 0 Flakiness 3

Details:

[stable26] Fix editing image description fails if enter isn't pressed
Project: Text Commit: 13c1816427
Status: Passed Duration: 04:53 💡
Started: May 4, 2023 8:01 AM Ended: May 4, 2023 8:06 AM
Flakiness  sync.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots
Flakiness  conflict.spec.js • 1 flaky test

View Output Video

Test Artifacts
Open test.md in viewer > resolves conflict using server version Output Screenshots
Flakiness  files.spec.js • 1 flaky test

View Output Video

Test Artifacts
Text and server mimetypes > handle plaintext in a pre tag Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr juliusknorr changed the title [Backport] Fix editing image description fails if enter isn't pressed [stable26] Fix editing image description fails if enter isn't pressed May 3, 2023
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels May 3, 2023
@juliusknorr juliusknorr added this to the Nextcloud 26.0.2 milestone May 3, 2023
@max-nextcloud max-nextcloud force-pushed the fix/image-caption-update-stable26 branch from 30f1ea1 to 57cb730 Compare May 4, 2023 07:30
@max-nextcloud
Copy link
Collaborator

/compile amend /

Signed-off-by: Luka Trovic <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the fix/image-caption-update-stable26 branch from 57cb730 to 13c1816 Compare May 4, 2023 07:38
@max-nextcloud max-nextcloud merged commit 141ddd1 into stable26 May 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/image-caption-update-stable26 branch May 4, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants