Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint-plugin-cypress to ^2.13.3 (stable26) #4017

Merged
merged 5 commits into from
May 3, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 31, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-plugin-cypress ^2.12.1 -> ^2.13.3 age adoption passing confidence

Release Notes

cypress-io/eslint-plugin-cypress

v2.13.3

Compare Source

Bug Fixes
  • handle ImportBindings in no-unnecessary-waiting rule (c626ad5)

v2.13.2

Compare Source

Bug Fixes
  • Wait incorrectly reported as unsafe to chain (7c20206)

v2.13.1

Compare Source

Bug Fixes

v2.13.0

Compare Source

Features
  • Add 'unsafe-to-chain-command' rule (bf6a75d)

Configuration

📅 Schedule: Branch creation - "before 5am every weekday,every weekend" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Mar 31, 2023
@renovate renovate bot requested review from a team, mejo- and datenangebot and removed request for a team March 31, 2023 22:05
@cypress
Copy link

cypress bot commented Mar 31, 2023

4 flaky tests on run #9584 ↗︎

0 142 1 0 Flakiness 4

Details:

chore(deps): update dependency eslint-plugin-cypress to ^2.13.2 (stable26)
Project: Text Commit: d457935bb4
Status: Passed Duration: 04:45 💡
Started: May 2, 2023 10:44 AM Ended: May 2, 2023 10:49 AM
Flakiness  workspace.spec.js • 2 flaky tests

View Output Video

Test Artifacts
Workspace > callouts > create callout Output Screenshots
Workspace > callouts > toggle callouts Output Screenshots
Flakiness  sync.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots
Flakiness  share.spec.js • 1 flaky test

View Output Video

Test Artifacts
Open test.md in viewer > Share a file with download disabled shows an error Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
Copy link
Member

Lots of those:

Error:   362:9  error  It is unsafe to chain further commands that rely on the subject after this command. It is best to split the chain, chaining again from `cy.` in a next command line  cypress/unsafe-to-chain-command

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@max-nextcloud max-nextcloud force-pushed the renovate/stable26-eslint-plugin-cypress-2.x branch from 8504b97 to 6fe0dff Compare April 28, 2023 10:29
@max-nextcloud
Copy link
Collaborator

/compile

@max-nextcloud max-nextcloud dismissed juliusknorr’s stale review May 2, 2023 10:15

applied the changes requested.

@max-nextcloud max-nextcloud force-pushed the renovate/stable26-eslint-plugin-cypress-2.x branch from bded6de to d457935 Compare May 2, 2023 10:16
@renovate renovate bot changed the title chore(deps): update dependency eslint-plugin-cypress to ^2.13.2 (stable26) chore(deps): update dependency eslint-plugin-cypress to ^2.13.3 (stable26) May 3, 2023
@renovate renovate bot force-pushed the renovate/stable26-eslint-plugin-cypress-2.x branch from d457935 to 5e0d152 Compare May 3, 2023 06:51
Makes the current eslint plugin pass.

Signed-off-by: Max <[email protected]>
Remove unnecessary `cy.getSubmenuEntry`
as it will open the parent menu.

This is a leftover from e9f54d0.

Signed-off-by: Max <[email protected]>
@renovate
Copy link
Contributor Author

renovate bot commented May 3, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@max-nextcloud
Copy link
Collaborator

/compile

Signed-off-by: nextcloud-command <[email protected]>
@max-nextcloud max-nextcloud merged commit e68da94 into stable26 May 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the renovate/stable26-eslint-plugin-cypress-2.x branch May 3, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants