Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table wrapper as scroll container for readonly tables #3998

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Mar 27, 2023

This fixes the table width and scroll behaviour in readonly mode.

This is a follow-up PR of #3910.

This fixes the table width and scroll behaviour in readonly mode.

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- added bug Something isn't working 3. to review labels Mar 27, 2023
@mejo-
Copy link
Member Author

mejo- commented Mar 27, 2023

/backport to stable26

@mejo-
Copy link
Member Author

mejo- commented Mar 27, 2023

/backport to stable25

@cypress
Copy link

cypress bot commented Mar 27, 2023

2 flaky tests on run #9237 ↗︎

0 142 1 0 Flakiness 2

Details:

Add table wrapper as scroll container for readonly tables
Project: Text Commit: 921c426749
Status: Passed Duration: 04:24 💡
Started: Mar 27, 2023 2:31 PM Ended: Mar 27, 2023 2:36 PM
Flakiness  sync.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots
Flakiness  share.spec.js • 1 flaky test

View Output Video

Test Artifacts
Open test.md in viewer > Share a file with download disabled shows an error Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo-
Copy link
Member Author

mejo- commented Mar 27, 2023

/compile

1 similar comment
@mejo-
Copy link
Member Author

mejo- commented Mar 27, 2023

/compile

Signed-off-by: nextcloud-command <[email protected]>
@mejo- mejo- merged commit 99c9c29 into main Mar 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/readyonly_table_width branch March 27, 2023 14:39
@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mejo-
Copy link
Member Author

mejo- commented Mar 27, 2023

/backport 4a30d2e to stable26

@mejo-
Copy link
Member Author

mejo- commented Mar 27, 2023

/backport 4a30d2e to stable25

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants