Fix front matter rendering #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the editor was loaded before the callback did not write the front matter content to the correct variable which resulted in dropping the front matter. This is fixed by not using the callback but a renderer function. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
feature: formatting
|
/compile |
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
1. Test if the correct front matter content is displayed 2. Test if the front matter survives closing and reopening the editor Skip common mark tests which we correctly interpret as front matter Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
susnux
force-pushed
the
fix/front-matter
branch
from
e21d523 to
984edbf
Compare
max-nextcloud
approved these changes
Nov 21, 2022
4 tasks
juliusknorr
added a commit
that referenced
this pull request
Nov 24, 2022
[Stable25] Backport of #3460 - Fix front matter rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This fixes an issue where front matters are not correctly rendered by markdown-it leading to an invalid tiptap state which is then the reason why front matters are sometimes dropped.
I also added a test for this.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)