Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Fix typo in serializePlainText #3402

Merged
merged 3 commits into from
Nov 9, 2022

Conversation

juliusknorr
Copy link
Member

backport of #2730

This reduces the console output as everytime a txt file is loaded
a exception is printed out that no matching language mapping is found
for txt.

Signed-off-by: Ferdinand Thiessen <[email protected]>
An empty text file should be serialized as `''` so fix
checking if the document only contains an empty code block
which type is `codeBlock` on tiptap v2 not `code_block`.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Nov 9, 2022
@juliusknorr juliusknorr added this to the Nextcloud 24.0.8 milestone Nov 9, 2022
@juliusknorr juliusknorr requested review from a team, marcelklehr, vinicius73 and max-nextcloud and removed request for a team November 9, 2022 12:20
@cypress
Copy link

cypress bot commented Nov 9, 2022



Test summary

52 0 0 0


Run details

Project Text
Status Passed
Commit 939af5d ℹ️
Started Nov 9, 2022 1:07 PM
Ended Nov 9, 2022 1:10 PM
Duration 03:24 💡
OS Linux Ubuntu - 20.04
Browser Electron 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@marcelklehr
Copy link
Member

/compile

Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr juliusknorr merged commit 154d7a6 into stable24 Nov 9, 2022
@juliusknorr juliusknorr deleted the backport/2730/stable24 branch November 9, 2022 13:19
@blizzz blizzz mentioned this pull request Nov 21, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants