Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add primary attribute for current user #2878

Merged
merged 3 commits into from
Sep 13, 2022

Conversation

luka-nextcloud
Copy link
Contributor

Signed-off-by: Luka Trovic [email protected]

Summary

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks good.
ESLint has some complains as can be seen in the Files changed tab.
Other than that seems good to go.

@luka-nextcloud luka-nextcloud force-pushed the bug/use-primary-attr-for-current-user-mention branch from 1236681 to a1d9461 Compare September 12, 2022 17:00
@luka-nextcloud
Copy link
Contributor Author

@max-nextcloud @vinicius73 Please check again.

@mejo-
Copy link
Member

mejo- commented Sep 13, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the bug/use-primary-attr-for-current-user-mention branch from a1d9461 to 640a1e1 Compare September 13, 2022 07:29
@mejo-
Copy link
Member

mejo- commented Sep 13, 2022

/compile

@mejo- mejo- force-pushed the bug/use-primary-attr-for-current-user-mention branch from 6a6c456 to 1b1b77a Compare September 13, 2022 07:58
@mejo-
Copy link
Member

mejo- commented Sep 13, 2022

I added a commit to fix the (unrelated) eslint warning introduced by #2867.

@mejo- mejo- force-pushed the bug/use-primary-attr-for-current-user-mention branch from 1b1b77a to 18a0598 Compare September 13, 2022 08:01
@mejo-
Copy link
Member

mejo- commented Sep 13, 2022

/compile amend

Signed-off-by: nextcloud-command <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the bug/use-primary-attr-for-current-user-mention branch from 18a0598 to 7f883b1 Compare September 13, 2022 08:05
@mejo- mejo- merged commit 6b7ea64 into master Sep 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the bug/use-primary-attr-for-current-user-mention branch September 13, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use primary attribute for current user mentions
5 participants