Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] add aria-keyshortcuts #2762

Conversation

vinicius73
Copy link
Member

@vinicius73 vinicius73 commented Jul 29, 2022

Summary

  • add missing aria-keyshortcuts
  • fix some shortcuts
    • strikethrough
    • ordered-list
    • blockquote
  • add missing shortcuts
    • code-block
  • improve mac compatibility
    • use command instead of control in Apple devices
  • add shortcuts tests

@juliusknorr
Copy link
Member

Also fixes #2445

@juliusknorr juliusknorr force-pushed the 2735-bitva11y-currently-keyboard-accessible-using-keyboard-shortcuts-common-in-text-editors-however-there-is-a-wai-aria-best-practice branch from a721c69 to 02330d7 Compare July 30, 2022 08:31
@vinicius73
Copy link
Member Author

/rebase

Vinicius Reis and others added 6 commits August 1, 2022 11:56
- strikethrough
- blockquote
Signed-off-by: Vinicius Reis <[email protected]>
Signed-off-by: Vinicius Reis <[email protected]>
Co-authored-by: Julius Härtl <[email protected]>
Signed-off-by: Vinicius Reis <[email protected]>
@nextcloud-command nextcloud-command force-pushed the 2735-bitva11y-currently-keyboard-accessible-using-keyboard-shortcuts-common-in-text-editors-however-there-is-a-wai-aria-best-practice branch from eaf3d57 to 6d8b6ac Compare August 1, 2022 11:56
@vinicius73
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <[email protected]>
@vinicius73 vinicius73 merged commit a84d082 into master Aug 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the 2735-bitva11y-currently-keyboard-accessible-using-keyboard-shortcuts-common-in-text-editors-however-there-is-a-wai-aria-best-practice branch August 1, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review accessibility enhancement New feature or request tests If you write them we ♥ you
Projects
None yet
5 participants