Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not unintended remove or modify link titles #2700

Merged
merged 2 commits into from
Jul 10, 2022
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 9, 2022

Summary

Keep the link title set in markdown as text is not using it, there is no reason to modify it.
Also added a test case for this.

@susnux susnux added bug Something isn't working 3. to review labels Jul 9, 2022
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks a lot for taking care of this!

@max-nextcloud
Copy link
Collaborator

/compile

Signed-off-by: nextcloud-command <[email protected]>
@max-nextcloud max-nextcloud merged commit cd4ab31 into master Jul 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/link-titles branch July 10, 2022 07:19
@max-nextcloud
Copy link
Collaborator

/backport to stable24

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@max-nextcloud
Copy link
Collaborator

/backport 0de91fd to stable24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link titles are removed
3 participants