Fix provided / injected extension list of BaseReader #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide functions are neither called on the providing object nor on the injecting object, so using `this` within provided functions will refer to the global `this` for which `$emit` is not defined. This uses a factory pattern so that `this` is bound to the injecting object. Also forwarding the `click-link` event is needed. Signed-off-by: Ferdinand Thiessen <[email protected]>
|
/compile amend |
mejo-
changed the title
|
/backport to stable24 |
Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/base-reader-injection
branch
from
6c6d726 to
4655d76
Compare
max-nextcloud
approved these changes
Jul 4, 2022
|
The backport to stable24 failed. Please do this backport manually. |
|
Thank you! |
|
there's no point in backporting this to stable24. The code in question did not exist there as far as i can tell. |
|
@max-nextcloud yes it was merged after 24.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #2628 by @susnux in order to allow our compile bot to push to the PR branch.
Summary
BaseReader: Use a factory pattern for creating the extension list
Provide functions are neither called on the providing object nor
on the injecting object, so using this within provided functions
will refer to the global this for which $emit is not defined.
This uses a factory pattern so that this is bound to the injecting
object.
Also forwarding the click-link event is needed.