Add image upload via drag'n'drop #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
force-pushed
the
enh/image-drag-n-drop
branch
from
6c316aa to
c3a1b17
Compare
|
/compile amend |
nextcloud-command
force-pushed
the
enh/image-drag-n-drop
branch
from
c3a1b17 to
2d78fed
Compare
julien-nc
force-pushed
the
enh/image-drag-n-drop
branch
3 times, most recently
from
331a2e4 to
69eb7ce
Compare
|
/compile amend |
nextcloud-command
force-pushed
the
enh/image-drag-n-drop
branch
from
69eb7ce to
d190de5
Compare
vinicius73
reviewed
Mar 30, 2022
src/components/EditorWrapper.vue
Outdated
| @@ -99,6 +108,18 @@ import { Step } from 'prosemirror-transform' | |||
|
|
|||
| const EDITOR_PUSH_DEBOUNCE = 200 | |||
|
|
|||
| const imageMimes = [ | |||
There was a problem hiding this comment.
Suggested change
| const imageMimes = [ | |
| const IMAGE_MIMES = [ |
src/components/EditorWrapper.vue
Outdated
| @@ -179,6 +200,8 @@ export default { | |||
| readOnly: true, | |||
| forceRecreate: false, | |||
| menubarLoaded: false, | |||
| nbUploadingImages: 0, | |||
There was a problem hiding this comment.
Suggested change
| nbUploadingImages: 0, | |
| uploadingImagesCount: 0, |
Closed
julien-nc
force-pushed
the
enh/image-drag-n-drop
branch
from
d190de5 to
b5df672
Compare
added 2 commits
March 30, 2022 13:20
remove image upload by link move 'image insertion from files' from MenuBar to EditorWrapper allow uploading multiple files Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/image-drag-n-drop
branch
from
b5df672 to
2942e04
Compare
vinicius73
approved these changes
Mar 30, 2022
|
/compile amend |
nextcloud-command
force-pushed
the
enh/image-drag-n-drop
branch
from
2942e04 to
7ff67b6
Compare
julien-nc
added
enhancement
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/image-drag-n-drop
branch
from
7ff67b6 to
6f619c0
Compare
) Signed-off-by: Julien Veyssier <[email protected]>
mejo-
approved these changes
Mar 31, 2022
src/components/EditorWrapper.vue
Outdated
| @@ -45,7 +50,10 @@ | |||
| :is-public="isPublic" | |||
| :autohide="autohide" | |||
| :loaded.sync="menubarLoaded" | |||
| @show-help="showHelp"> | |||
| :uploading-image="uploadingImages" | |||
There was a problem hiding this comment.
For consistency, the uploadingImage property in MenuBar should maybe be named uploadingImages as well?
|
/compile amend |
nextcloud-command
force-pushed
the
enh/image-drag-n-drop
branch
from
9bc6832 to
38be106
Compare
julien-nc
force-pushed
the
enh/image-drag-n-drop
branch
from
38be106 to
c38fb17
Compare
|
/compile amend |
Signed-off-by: Julien Veyssier <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
enh/image-drag-n-drop
branch
from
c38fb17 to
5bdc049
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes those changes:
We imitate what's done style-wise in Files when dragging stuff over: set background color to
--color-primary-light.