Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rich workspaces overlap with new file dropdown #1574

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

gary-kim
Copy link
Member

@gary-kim gary-kim commented Apr 26, 2021

Fix https://github.com/nextcloud/server/issues/27588

  • Target version: master

Before

Screenshot 2021-04-26 at 14-03-29 Talk

After

Screenshot 2021-04-26 at 14-00-00 Talk

@gary-kim gary-kim added bug Something isn't working 3. to review labels Apr 26, 2021
@gary-kim gary-kim added this to the Nextcloud 22 milestone Apr 26, 2021
@gary-kim gary-kim requested a review from juliusknorr April 26, 2021 18:05
@gary-kim gary-kim force-pushed the fix/noid/overlap branch 2 times, most recently from 11386e5 to 966f4ee Compare May 20, 2021 17:24
@gary-kim
Copy link
Member Author

Rebased

@gary-kim
Copy link
Member Author

@juliushaertl Could you take a look when you have time? Thanks.

@MorrisJobke MorrisJobke mentioned this pull request May 26, 2021
98 tasks
@blizzz blizzz mentioned this pull request Jun 2, 2021
57 tasks
@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
59 tasks
@blizzz blizzz modified the milestones: Nextcloud 22, Nextcloud 23 Jun 24, 2021
@szaimen
Copy link
Contributor

szaimen commented Jul 1, 2021

/rebase

@szaimen
Copy link
Contributor

szaimen commented Jul 1, 2021

/compile amend /

@@ -638,7 +638,7 @@ export default {
#editor {
overflow: auto;
// Fix for IE11 issue where the menubar sometimes was positioned under the text
z-index: 1000;
z-index: 20;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind to drop the comment above since with the removed IE11 support this is no longer required and caused side effects the bug the pr fixes ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@juliusknorr
Copy link
Member

Sorry for taking so long for the review, I have a small comment, but tested and works fine otherwise 👍

@szaimen
Copy link
Contributor

szaimen commented Jul 14, 2021

I wonder what the difference to this PR is: #1631

@juliusknorr
Copy link
Member

The position: unset; that is currently set on #editor-wrapper basically moves the element into the regular stacking context and will be above any element due to its order in the dom. Since the #editor has 10000 (which is adjusted in this PR), the 10000 are in the regular stacking context. The other PR creates a new stacking context (which would have an implicit z-index of 0 as non is set on that element) so the 10000 no longer are taken into the global but the local stacking context of the parent only.

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Positioning/Understanding_z_index/Stacking_without_z-index and
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Positioning/Understanding_z_index/The_stacking_context might be a good first read on the topics.

The second PR would be a good possible addition to avoid further overlay issues, but I need to do some further testing on that.

@juliusknorr juliusknorr merged commit 4c69402 into master Jul 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/overlap branch July 15, 2021 06:09
@juliusknorr
Copy link
Member

/backport to stable22

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@szaimen
Copy link
Contributor

szaimen commented Jul 15, 2021

Created the backport manually in #1769

@szaimen
Copy link
Contributor

szaimen commented Jul 15, 2021

/backport to stable21

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@szaimen
Copy link
Contributor

szaimen commented Jul 15, 2021

Created the backport manually in #1770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants