Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table cells containing repeated newlines get garbled #5737

Closed
asmecher opened this issue May 2, 2024 · 6 comments · Fixed by #6316
Closed

Table cells containing repeated newlines get garbled #5737

asmecher opened this issue May 2, 2024 · 6 comments · Fixed by #6316
Assignees
Labels
0. Needs triage bug Something isn't working feature: formatting Features related to text formatting and node types

Comments

@asmecher
Copy link

asmecher commented May 2, 2024

Describe the bug
When a collective contains a table, and the table cell contains consecutive newlines, the content gets garbled with a save/reload cycle.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new page inside a Collective.
  2. Insert a table into it.
  3. Enter content into a cell containing consecutive newlines.
    image
    (I entered these by copying a newline from the table and pasting it a couple times.)
  4. Save the page
  5. Load the page. See the changed content:
    image

The content appears to jump boundaries in the Markdown representation.

I would have filed this in the Nextcloud text editor repo, but I'm not able to reproduce the problem outside of Collectives, oddly!

Expected behavior
The text should be unchanged after a save/reload cycle.

Server details:

  • Collectives app version: 2.9.1
  • Nextcloud version: 27.1.3
  • PHP Version: 8.1.25
  • Database: PostgreSQL 15.5

Client details:

  • OS: Ubuntu
  • Browser: Firefox
  • Browser version: 125.0.2
  • Device: Desktop
@asmecher asmecher added the bug Something isn't working label May 2, 2024
@mejo-
Copy link
Member

mejo- commented May 2, 2024

Dear @asmecher, thanks for your report. This most likely is an issue in the Text app, thus I'll transfer the issue there.

@mejo- mejo- transferred this issue from nextcloud/collectives May 2, 2024
@mejo- mejo- changed the title Collectives containing tables: cells containing repeated newlines get garbled Table cells containing repeated newlines get garbled May 2, 2024
@mejo- mejo- added feature: formatting Features related to text formatting and node types 0. Needs triage labels May 2, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team May 2, 2024
@asmecher
Copy link
Author

asmecher commented May 2, 2024

Thanks, @mejo- -- as I've noted above, I wasn't able to reproduce the issue in the text editor e.g. in Files, but could easily reproduce it in Collectives. Not sure why the difference.

@mejo-
Copy link
Member

mejo- commented May 3, 2024

I tried to reproduce this with Collectives 2.10.1 on Nextcloud 29 an failed so far. Though there were some Tables related fixes in recent Text versions and you seem to run pretty outdated Nextcloud + Collectives versions. Could you upgrade your instance to Nextcloud 27.1.9 at least (ideally Nextcloud 28.0.5) and Collectives to 2.10.1 and see whether you're still able to reproduce the issue then?

@asmecher
Copy link
Author

I've requested an upgrade, and will confirm the new version and whether the bug is reproducible when we've been able to get to it.

@asmecher
Copy link
Author

I've upgraded to Collectives 2.12.0 and Nextcloud 29.0.2, and I can still reproduce the problem. If it helps, it appears you have to copy/paste multi-line content from a plaintext source, like a programmer's text editor.

nextcloud.mp4

@mejo- mejo- removed the needs info label Sep 4, 2024
@mejo-
Copy link
Member

mejo- commented Sep 4, 2024

Indeed, still reproducible when pasting block content with newlines into a table cell.

Manually adding newlines in a table cell on the other hand works as expected.

@mejo- mejo- self-assigned this Sep 4, 2024
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Office team Sep 4, 2024
mejo- added a commit that referenced this issue Sep 4, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Sep 5, 2024
backportbot bot pushed a commit that referenced this issue Sep 5, 2024
backportbot bot pushed a commit that referenced this issue Sep 5, 2024
backportbot bot pushed a commit that referenced this issue Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage bug Something isn't working feature: formatting Features related to text formatting and node types
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants