Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back author colors #3731

Open
max-nextcloud opened this issue Feb 1, 2023 · 0 comments
Open

Bring back author colors #3731

max-nextcloud opened this issue Feb 1, 2023 · 0 comments
Assignees
@max-nextcloud
Labels
1. to develop 26 feedback enhancement New feature or request regression

Comments

@max-nextcloud
Copy link
Collaborator

Author colors were removed during the yjs rework.
Bring them back.

Approaches:

  • Either use awareness state and have each user announce their author colors and a list of segments they wrote similar to how the user cursor plugin works
  • Or use a separate datastructure within the yjs document to maintain a list of authorship
@max-nextcloud max-nextcloud mentioned this issue Feb 1, 2023
Closed
6 tasks
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Feb 21, 2023
@juliusknorr juliusknorr moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Feb 21, 2023
@juliusknorr juliusknorr moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📝 Office team Jun 1, 2023
@juliusknorr juliusknorr moved this from 🏗️ In progress to 🧭 Planning evaluation (don't pick) in 📝 Office team Jan 19, 2024
mejo- added a commit that referenced this issue Jul 9, 2024
@mejo-
chore(editor): Remove obsolete code for author annotations
94ef596 
We probably want to bring this back at some point, but currently it's
just dead code.

Related: #3731

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- mentioned this issue Jul 9, 2024
Merged
2 tasks
mejo- added a commit that referenced this issue Jul 9, 2024
@mejo-
chore(editor): Remove obsolete code for author annotations
2dab960 
We probably want to bring this back at some point, but currently it's
just dead code.

Related: #3731

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- mentioned this issue Sep 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@max-nextcloud max-nextcloud

Labels
1. to develop 26 feedback enhancement New feature or request regression
Projects
📝 Office team
Status: 🧭 Planning evaluation (don't pick)
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juliusknorr @mejo- @max-nextcloud