Avoid cumulative layout shifts on Files pages #2834
Labels
Comments
marcelklehr
changed the title
9 tasks
3 tasks
mejo-
added a commit
that referenced
this issue
Jun 7, 2023
Instead of only increasing page height with growing document length, let's stick to a fixed height (30vh) and use that one already while loading the document. Fixes: #2834 Fixes: #2803 Signed-off-by: Jonas <[email protected]>
mejo-
added a commit
that referenced
this issue
Jun 7, 2023
Instead of only increasing page height with growing document length, let's stick to a fixed height (30vh) and use that one already while loading the document. Fixes: #2834 Fixes: #2803 Signed-off-by: Jonas <[email protected]>
mejo-
added a commit
that referenced
this issue
Jun 7, 2023
Instead of only increasing editor height with growing document length, let's stick to a fixed height (25vh) and use that one already while loading the document. The editor still increases when it gets focused. Fixes: #2834 Fixes: #2803 Signed-off-by: Jonas <[email protected]>
mejo-
added a commit
that referenced
this issue
Jun 14, 2023
Instead of only increasing editor height with growing document length, let's stick to a fixed height (25vh) and use that one already while loading the document. The editor still increases when it gets focused. Fixes: #2834 Fixes: #2803 Signed-off-by: Jonas <[email protected]>
mejo-
added a commit
that referenced
this issue
Jun 14, 2023
Instead of only increasing editor height with growing document length, let's stick to a fixed height (150px) and use that one already while loading the document. The editor still increases when it gets focused. Fixes: #2834 Fixes: #2803 Signed-off-by: Jonas <[email protected]>
|
Fixed by #2834 |
github-project-automation
bot
moved this from 🧭 Planning evaluation (don't pick)
to ☑️ Done
in 📝 Office team
Closed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Loading a files page shows the following:
The problem is that (3) typically loads first, then (2) then (1). But 2 and 1 cause cumulative layout shifts (CLS) which means things like: you click on one folder, but just as you click, the layout shifts and now you've clicked on a different one - but you might not notice until the next page loads.
On my server (which is not going to win prizes for being high-end) the loading times for (2) and (1) can be anywhere up to a minute! So it's anyone's guess where your click is going to land. I have NC on a better server and there the problem is not so pronounced, but it is still a problem - you're waiting maybe 8-10s to be able to trust the interface has settled.
Describe the solution you'd like
A really simple solution would be to fix the amount of space allowed for README and recent files so that the layout shift is avoided.
Performance improvements could also really help.
Describe alternatives you've considered
I've considered looking for a way to turn off README and recent docs, but they have their uses.
The text was updated successfully, but these errors were encountered: