Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for autolink (tiptap v2) #2097

Closed
ya-d opened this issue Jan 14, 2022 · 2 comments · Fixed by #2316
Closed

Add support for autolink (tiptap v2) #2097

ya-d opened this issue Jan 14, 2022 · 2 comments · Fixed by #2316
Assignees
@vinicius73
Labels
3. to review enhancement New feature or request
Milestone
Nextcloud 24

Comments

@ya-d
Copy link

ya-d commented Jan 14, 2022 •
edited
Loading

Tiptap v2 adds support for autolink and creates hyperlinks automatically when URLs are inserted by typing oder pasting.

It would be nice if Text would support that as well. Thanks for considering!

Related to #1906 #1981
@ya-d ya-d added the enhancement New feature or request label Jan 14, 2022
@mejo- mejo- added this to the Nextcloud 24 milestone Apr 17, 2022
@mejo-
Copy link
Member

mejo- commented Apr 17, 2022

Interesting, this should be enabled per default with tiptap v2 (see https://tiptap.dev/api/marks/link#autolink), but for some reason it doesn't work in latest Text 🤔

Seems like our custom addProseMirrorPlugins() in https://github.com/nextcloud/text/blob/master/src/marks/Link.js#L55 overwrites the default plugins autolink, onOpenClick and linkOnPaste. For linkOnPaste, this probably even is a regression in Nextcloud 24.

@vinicius73
Copy link
Member

Yes @mejo- , we must fix it.
I will work on it.

@vinicius73 vinicius73 self-assigned this Apr 19, 2022
vinicius73 pushed a commit that referenced this issue Apr 19, 2022
🐛 (#2097): add support to autolink
ed31545 
auto link is included in original tiptap extension-link.

We should keep the original behavior as much as possible.

Signed-off-by: Vinicius Reis <[email protected]>
vinicius73 pushed a commit that referenced this issue Apr 19, 2022
✅ (#2097): add link integration tests
a555ff0 
Signed-off-by: Vinicius Reis <[email protected]>
@vinicius73 vinicius73 mentioned this issue Apr 19, 2022
Merged
vinicius73 pushed a commit that referenced this issue Apr 20, 2022
✅ (#2097): improve login action
fdf2829 
Signed-off-by: Vinicius Reis <[email protected]>
vinicius73 pushed a commit that referenced this issue Apr 20, 2022
✅ (#2097): use calledWithMatch instead of calledWith
e2cc1cb
vinicius73 pushed a commit that referenced this issue Apr 20, 2022
✅ (#2097): use calledWithMatch instead of calledWith
55ee9b6 
Signed-off-by: Vinicius Reis <[email protected]>
vinicius73 pushed a commit that referenced this issue Apr 20, 2022
🔀 (#2097): backport to stable24
3a22042 
manually applied from #2316 and #2318

Signed-off-by: Vinicius Reis <[email protected]>
@vinicius73 vinicius73 mentioned this issue Apr 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinicius73 vinicius73

Labels
3. to review enhancement New feature or request
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging a pull request may close this issue.

Bugfix: add support to auto link nextcloud/text
4 participants
@vinicius73 @juliusknorr @mejo- @ya-d