Support NC12 #23

GitHubUser4234 · 2017-06-22T10:50:05Z

Hi,

Please release the mail template editor for NC 12, it's desperately needed, thanks!

nickvergessen · 2017-06-22T10:51:30Z

Well the main issue is, that the emails are now themed with the new email template system.
There for the files this app used do not exist anymore.

What exactly do you want to change?

GitHubUser4234 · 2017-06-22T11:05:56Z

Well the main issue is, that the emails are now themed with the new email template system.
There for the files this app used do not exist anymore.

What exactly do you want to change?

The goal is to be able to do the same as this app does. In our case we currently have defined the email content in email.new_user.php and email.new_user_plain_text.php. Is there a way to do this same as comfortably in the new email template system? A pointer where to find more info would be great, thanks.

But then, how come the app will be supported for NC13? 😄

nickvergessen · 2017-06-22T11:14:34Z

Yeah so what do you want to change? the text of the email? the layout? add additional info?

If you want to change stuff for all emails, you can overwrite the EmailTemplate in the config with 12.0.1 and later: https://github.com/nextcloud/server/blob/8760abae636b1c6f3f37e78300b318adb98d0220/config/config.sample.php#L969-L974

GitHubUser4234 · 2017-06-23T06:52:33Z

Yeah so what do you want to change? the text of the email? the layout? add additional info?

Text as well as layout.

If you want to change stuff for all emails, you can overwrite the EmailTemplate in the config with 12.0.1 and later: https://github.com/nextcloud/server/blob/8760abae636b1c6f3f37e78300b318adb98d0220/config/config.sample.php#L969-L974

Thanks for the pointer. However it doesn't look like the same, as the text of individual doesn't seem to be editable? And not as convenient as this app where things can be achieved by just quickly modifying some HTML.

It would be really awesome if this app could support NC12, after all support for NC13 is in the cards. It's really sad that with the NC12 upgrade, features like the ones offered by this app are not available anymore 😿

Seems others have also reported this problem:

https://help.nextcloud.com/t/email-templates-missing-nc-12/14356
https://help.nextcloud.com/t/missing-mailtemplate-editor/15114

fabianblum · 2017-08-09T19:25:19Z

Please update the manual if there is no Theming posibility in the admin page (https://docs.nextcloud.com/server/12/developer_manual/core/theming.html)

TheMrApostel · 2017-08-11T15:19:39Z

@nickvergessen
But how do i change the existing text?

TheMrApostel · 2017-08-17T20:12:50Z

Ping

marley-ma · 2017-08-25T17:01:39Z

@TheMrApostel you can do this via translation layer. But it is a terrible approach!

@nickvergessen as mentioned above please update the manual!!!

@nickvergessen I looked closer at the source code of OC\Mail\EMailTemplate::class and I think it would be worthwhile to remake the mentioned class. A better approach to solve this, would certainly be to retrieve HTML parts individually from external file and not to define HTML as class properties directly in the given container. It is quite logical if we want to use our custom NextCloud theme so that we can also customize the layout of system emails without interfering with the PHP object.

nickvergessen · 2017-08-25T19:04:57Z

Well the idea is that you create your own EmailTemplate class and then replace it the config.php. Then you can change the HTML as you prefer. For the next version we will add identifiers, so you can also only modify some emails.

And feel free to update the documentation with any changes you need

SkyWheel · 2017-08-30T02:07:08Z

So, in other words, there is no way to change an email template from web console?

nickvergessen · 2017-08-30T11:50:57Z

Exactly, it's not there anymore, because if you break the php syntax by missing out a semicolon or something similar, you break sending the email completly.

TheMrApostel · 2017-08-31T07:18:58Z

Can someone please point me where i can change the code of OC\Mail\EMailTemplate::class?
It is still unclear to me where OC\Mail\EMailTemplate is located on my system.

marley-ma · 2017-08-31T12:14:42Z

@TheMrApostel it isn't good idea change code in OC\Mail\EMailTemplate::class.

Better way is create your own class like this example:

Create your own OC\Mail\EMailTemplate::class extension

<?php namespace MyVendor;

use OC\Mail\EMailTemplate;

class MyClass extends EMailTemplate
{
      // there you can do what will you do
}

Then in config/config.php change mail_template_class to your class namespace

'mail_template_class' => MyVendor\MyClass::class

msberends · 2017-09-04T05:29:16Z

Better way is create your own class like this example:

I find this hard to understand. Where do I save such a PHP file then? Somewhere in my /themes/MyTheme/core folder?

nickvergessen · 2017-09-04T11:04:11Z

The clean way would be to have a dedicated app for it.
The otherway would be to just throw it into the normal source folder next to the existing one, but that will break with every update. So it's better to create your own app.

@MariusBluem status of the post I gave you?

msberends · 2017-09-04T12:24:58Z

The clean way would be to have a dedicated app for it.

That might be at the moment, but as NextCloud supports theming directly (hence the admin menu) I think this should be part of that menu. Creating an app has a really really steep learning curve (from my own experience with ownCloud, which app containers are the same). A decent UI on the admin page would benefit most admins far better. Not every admin (personal or professional) is a developer. Most are just maintainers. I really think that this should be part of the core functions... just as ownCloud.

TheMrApostel · 2017-09-04T18:57:12Z

@marley-ma @msberends

I find this also hard to understand. I had no problems by creating an webserver and install nextcloud with ldap and so on but i do not unterstand how to create my own extension. Can i copy and paste the code from NC11 there?

I also think that this should be a part of the core functions.
The new mail template is way too personal and inflexible.

JK74 · 2017-09-06T13:57:44Z

@nickvergessen I'm now a bit confused as this issue is now closed but pointing to another thread #5180 however that thread is now pointing as well back to this one. The circle is round but still no fix? Or a future enhancement? Or do we get 2 more lines in the admin page that can be included in the invite e-mail for new users? Please advise as this is confusing. thanks!

nickvergessen · 2017-09-06T14:02:28Z

Well see the comment from marley-ma above. It holds the info you are looking for

msberends · 2017-09-06T14:23:08Z

Uhm, right. I’ll consider the template editor unsupported on NC12. Even my theme logo isn’t in the mail :(

Anyway, thanks for your time.

marley-ma · 2017-09-06T17:32:06Z

@msberends are you sure that you have logo-mail.gif file in your theme?

see here

msberends · 2017-09-06T17:50:07Z

Ah, thanks!!! I’ll convert my logo.svg right away.

TheMrApostel · 2017-09-08T13:15:51Z

@nickvergessen
So i just have to paste the text of my NC11 template in the code of @marley-ma ?
For example the standard template of NC11:

<?php namespace MyVendor;

use OC\Mail\EMailTemplate;

class MyClass extends EMailTemplate
{
<table cellspacing="0" cellpadding="0" border="0" width="100%">
	<tr><td>
			<table cellspacing="0" cellpadding="0" border="0" width="600px">
				<tr>
					<td colspan="2" bgcolor="<?php p($theme->getMailHeaderColor());?>">
						<img src="<?php p(\OC::$server->getURLGenerator()->getAbsoluteURL(image_path('', 'logo-mail.png'))); ?>" alt="<?php p($theme->getName()); ?>"/>
					</td>
				</tr>
				<tr><td colspan="2">&nbsp;</td></tr>
				<tr>
					<td width="20px">&nbsp;</td>
					<td style="font-weight:normal; font-size:0.8em; line-height:1.2em; font-family:verdana,'arial',sans;">
						<?php
						if ($_['onBehalfOf']) {
							print_unescaped($l->t('Hey there,<br><br>%s shared <a href="%s">%s</a> with you on behalf of %s.<br><br>', [$_['owner'], $_['link'], $_['filename'], $_['initiator']]));
						} else {
							print_unescaped($l->t('Hey there,<br><br>%s shared <a href="%s">%s</a> with you.<br><br>', [$_['owner'], $_['link'], $_['filename']]));
						}
						// TRANSLATORS term at the end of a mail
						p($l->t('Cheers!'));
						?>
					</td>
				</tr>
				<tr><td colspan="2">&nbsp;</td></tr>
				<tr>
					<td width="20px">&nbsp;</td>
					<td style="font-weight:normal; font-size:0.8em; line-height:1.2em; font-family:verdana,'arial',sans;">--<br>
						<?php p($theme->getName()); ?> -
						<?php p($theme->getSlogan()); ?>
						<br><a href="<?php p($theme->getBaseUrl()); ?>"><?php p($theme->getBaseUrl());?></a>
					</td>
				</tr>
				<tr>
					<td colspan="2">&nbsp;</td>
				</tr>
			</table>
		</td></tr>
</table>
}

marley-ma · 2017-09-08T18:10:29Z

@TheMrApostel no, that's not right.

Look at the source code of extended class OC\Mail\EMailTemplate::class
Then override what you need in your class extension

Example

Let's assume that we need override email header.

<?php namespace MyVendor;

use OC\Mail\EMailTemplate;

class MyClass extends EMailTemplate
{
    protected $header = <<<EOF 
        <table align="center" class="wrapper">
            // your theme email header modification
        </table>
    EOF;
}

Don't forget to set your class in the configuration. See point 2 in this comment

TheMrApostel · 2017-09-16T16:13:19Z

@marley-ma
I'm very sorry but i still dont get it.
From my understanding you can only change the template / design of the email.
I want to add some additional text / information. I took a look and the source code you had pointed me but i didn't found any text elements :(

Thank you for your kind help!

GitHubUser4234 · 2017-09-17T15:05:42Z

I'm very sorry but i still dont get it.
From my understanding you can only change the template / design of the email.
I want to add some additional text / information. I took a look and the source code you had pointed me but i didn't found any text elements :(

Thank you for your kind help!

It looks like exactly that isn't possible, at least for individual emails? That's why this app (templateeditor) would still be needed but it doesn't support NC12.

JimmyKater · 2017-09-26T08:19:25Z

@nickvergessen

The clean way would be to have a dedicated app for it.

well... i'm afraid there WAS such an app. and as much as i can understand why you removed it from the appstore i am wondering why you don't just update it since it seems soooooooooo easy, as you implied in another posting from above.
and yes, email-template-changings are part of the official nc12-manual (so it most prolly will be dropped completely in nc13+, right?).

well to cut a long story short: a thing like "editing email-templates" is needed. and it should be an app itself (since modifying source code with every update isn't the best thing to do - as you put out earlier, yourself).

nickvergessen · 2017-09-26T12:06:45Z

It looks like exactly that isn't possible, at least for individual emails? That's why this app (templateeditor) would still be needed but it doesn't support NC12.

This is possible with the new way as well. In 12.0.3 we added identifiers so text can be added to individual emails only.

As explain already multiple times, we won't fix this app or build a new one, because it's to complicated to make sure stuff still works correctly when we change an email. E.g. when we add a new feature to an email or remove one.

JK74 · 2017-09-26T14:52:26Z

Nick, maybe I missed it from the release notes for 1203 but where is it documented how to change some e-mails? thnx again, Jeroen

JaredBoone · 2017-10-11T20:08:15Z

I was able to build a dedicated app and override the EMailTemplate class as described above. Thanks for pointing me in the right direction @nickvergessen .

I'll also add my voice to the chorus and say that I would like to see better support for custom email templates in the core application.

msberends · 2017-10-12T05:35:42Z

That’s great Jared! Please share it using the App Store :)

alanlo52 · 2017-11-07T10:57:32Z

is there any update on this?
and i'm wonder how to create my own OC\Mail\EMailTemplate::class extension to where?

MorrisJobke · 2018-03-16T20:36:30Z

and i'm wonder how to create my own OC\Mail\EMailTemplate::class extension to where?

See nextcloud/server#8350 (comment) for more details.

rubo77 · 2018-08-23T12:24:42Z

Here is a good explanation how to create your own template: https://help.nextcloud.com/t/solved-custimze-emails/23931/3

you can find the EmailTemplate in the following directory : nextcloud/lib/private/Mail/
Make a copy of the template and rename it. (Ex: NewEmailTemplate)
Make all the change you need in your new email template
then in the config.php (nextcloud/config/) add the following line
’mail_template_class’ => ’ \OC\Mail\NameOfYourEmailTemplate’,

SkyWheel · 2018-08-23T12:40:13Z

And what Nextcloud-snap users should do?

nickvergessen mentioned this issue Sep 6, 2017

e-mail template change not available any longer? nextcloud/server#5180

Closed

splitt3r mentioned this issue Nov 20, 2017

Mail template editor missing in default installation nextcloud/server#5152

Closed

MorrisJobke mentioned this issue Mar 16, 2018

e-mail templates editor is missing NC13 nextcloud/server#8350

Closed

MorrisJobke closed this as completed Mar 16, 2018

Support NC12 #23

Support NC12 #23

Comments

GitHubUser4234 commented Jun 22, 2017

nickvergessen commented Jun 22, 2017

GitHubUser4234 commented Jun 22, 2017 • edited Loading

nickvergessen commented Jun 22, 2017

GitHubUser4234 commented Jun 23, 2017 • edited Loading

fabianblum commented Aug 9, 2017

TheMrApostel commented Aug 11, 2017

TheMrApostel commented Aug 17, 2017

marley-ma commented Aug 25, 2017 • edited Loading

nickvergessen commented Aug 25, 2017

SkyWheel commented Aug 30, 2017

nickvergessen commented Aug 30, 2017

TheMrApostel commented Aug 31, 2017

marley-ma commented Aug 31, 2017

msberends commented Sep 4, 2017

nickvergessen commented Sep 4, 2017

msberends commented Sep 4, 2017 via email

TheMrApostel commented Sep 4, 2017

JK74 commented Sep 6, 2017

nickvergessen commented Sep 6, 2017

msberends commented Sep 6, 2017

marley-ma commented Sep 6, 2017

msberends commented Sep 6, 2017 via email

TheMrApostel commented Sep 8, 2017 • edited Loading

marley-ma commented Sep 8, 2017

TheMrApostel commented Sep 16, 2017

GitHubUser4234 commented Sep 17, 2017 • edited Loading

JimmyKater commented Sep 26, 2017

nickvergessen commented Sep 26, 2017

JK74 commented Sep 26, 2017

JaredBoone commented Oct 11, 2017

msberends commented Oct 12, 2017 via email

alanlo52 commented Nov 7, 2017

MorrisJobke commented Mar 16, 2018

rubo77 commented Aug 23, 2018 • edited Loading

SkyWheel commented Aug 23, 2018

GitHubUser4234 commented Jun 22, 2017 •

edited

Loading

GitHubUser4234 commented Jun 23, 2017 •

edited

Loading

marley-ma commented Aug 25, 2017 •

edited

Loading

TheMrApostel commented Sep 8, 2017 •

edited

Loading

GitHubUser4234 commented Sep 17, 2017 •

edited

Loading

rubo77 commented Aug 23, 2018 •

edited

Loading