chore: remove unused npm dependencies #2763
Conversation
| "sortablejs-vue3": "^1.2.11", | ||
| "uuid": "^11.0.5", |
There was a problem hiding this comment.
@nextcloud/[email protected]. It has to be removed there first before we can remove it here.
Depends on nextcloud/calendar-js#785.
There was a problem hiding this comment.
PR was merged, released in v8.1.0 and added in 24723da.
| @@ -27,7 +27,6 @@ | |||
| "bugs": "https://github.com/nextcloud/tasks/issues", | |||
| "contributors": [], | |||
| "dependencies": { | |||
| "@nextcloud/auth": "^2.4.0", | |||
There was a problem hiding this comment.
This is a direct dependency of @nextcloud/axios but not used directly in the code (via import).
| @@ -43,15 +42,12 @@ | |||
| "color-convert": "^2.0.1", | |||
| "debounce": "^2.2.0", | |||
| "ical.js": "^2.1.0", | |||
| "linkify-it": "^5.0.0", | |||
There was a problem hiding this comment.
This is a direct dependency of markdown-it.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
jaylinski
force-pushed
the
chore/remove-unused-npm-deps
branch
from
e686cd6 to
af6544d
Compare
Signed-off-by: Jakob Linskeseder <[email protected]>
jaylinski
force-pushed
the
chore/remove-unused-npm-deps
branch
from
af6544d to
ca29a87
Compare
When running
npm run buildthe size of/js/store-C4tptVlq.chunk.mjswill shrink by 0.28 kB (gzip).The
npm cicommand is now about 0.5 to 1.0 seconds faster.The
npm installcommand now installs 990 dependencies instead of 993.