detekt improvements

[AndyScherzinger]

🖼️ Score

🏚️ Before	🏡 After
99	82

🚧 TODO

• get refactorings reviewed

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[AndyScherzinger]

Especially https://github.com/nextcloud/talk-android/pull/4544/files#diff-613b4702fd5108bfa720e7a128cd700663fd46f7e5b8c5207c04088899cfb0b4

[mahibi]

ah only now saw that "to review" was removed :D

[AndyScherzinger]

@mahibi Yes, some checks failed, so I removed the review label.
Pushed a fix, so check should turn green again now and hence ready to review/merge if the changes look good to you.

[AndyScherzinger]

I didn't want to put to many changes in since shortening methods leads to quite some code being moved around... Hence I am splitting these changes into several PRs, to drive that check to zero occurences

[AndyScherzinger]

/backport to stable-20.1

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	158	158
Errors	72	71

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	16	16
Dodgy code	71	71
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	104	104

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4544-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.