Fetch messages in background #4475
Conversation
|
not to be merged for 20.1.0, might review only afterwards |
There was a problem hiding this comment.
something is wrong with the chatBlocks, they don't get merged correctly (i guess because "lastKnown" in the fieldMap is not set up correctly). In the UI this leads to the fact that the newest loaded message is shown first, and then the older messages appear. With correctly merged chatBlocks this should not happen.
There is a high danger to introduce serious bugs when something is wrong with the chatBlocks, so i might be quite nitpicky with this PR ;)
| @@ -446,6 +449,34 @@ class ConversationsListActivity : | |||
| updateFilterConversationButtonColor() | |||
| } | |||
|
|
|||
| private fun List<ConversationModel>.refreshMessages() { | |||
There was a problem hiding this comment.
As we already have a ConversationListViewModel we should use this, so as the code is just about data handling it should not be in the Activity.
mahibi
force-pushed
the
issue-4381-fetch-messages-in-background
branch
2 times, most recently
from
9bf582b to
7dfc82c
Compare
|
fyi @rapterjet2004 i rebased on master... |
Signed-off-by: rapterjet2004 <[email protected]> Got it loading on refresh Signed-off-by: rapterjet2004 <[email protected]> linter Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
rapterjet2004
force-pushed
the
issue-4381-fetch-messages-in-background
branch
from
7dfc82c to
9b756d4
Compare
Signed-off-by: rapterjet2004 <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4475-talk.apk |
Fetches messages and saves them when refreshing the conversation list. Only refreshes what is needed, to save battery.
🏁 Checklist
/backport to stable-xx.x