-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detect when user is talking and send data channel message #3298
detect when user is talking and send data channel message #3298
Conversation
3ac8e39
to
03517f2
Compare
/backport to stable-17.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just an additional lint warning
810e32a
to
e839f6f
Compare
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
e839f6f
to
fd248f0
Compare
Signed-off-by: github-actions <[email protected]>
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3298-talk.apk |
The backport to stable-17.1 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable-17.1
git pull origin stable-17.1
# Create the new backport branch
git checkout -b fix/foo-stable-17.1
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-17.1 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/backport to stable-17.1 |
The backport to stable-17.1 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable-17.1
git pull origin stable-17.1
# Create the new backport branch
git checkout -b fix/foo-stable-17.1
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-17.1 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
resolve #88
🏁 Checklist
/backport to stable-xx.x