Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect when user is talking and send data channel message #3298

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Sep 5, 2023

resolve #88

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi force-pushed the feature/88/detectTalkingAndSendDataChannelMessage branch from 3ac8e39 to 03517f2 Compare September 5, 2023 12:20
@mahibi
Copy link
Collaborator Author

mahibi commented Sep 5, 2023

/backport to stable-17.1

@mahibi mahibi added this to the 17.2.0 milestone Sep 5, 2023
@mahibi mahibi self-assigned this Sep 5, 2023
@mahibi mahibi added the 3. to review Waiting for reviews label Sep 5, 2023
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just an additional lint warning

@mahibi mahibi force-pushed the feature/88/detectTalkingAndSendDataChannelMessage branch from 810e32a to e839f6f Compare September 6, 2023 10:24
@mahibi mahibi force-pushed the feature/88/detectTalkingAndSendDataChannelMessage branch from e839f6f to fd248f0 Compare September 6, 2023 10:59
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Codacy

Lint

TypemasterPR
Warnings9493
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total150150

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3298-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit bc7939f into master Sep 6, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/88/detectTalkingAndSendDataChannelMessage branch September 6, 2023 11:29
@backportbot-nextcloud
Copy link

The backport to stable-17.1 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-17.1
git pull origin stable-17.1

# Create the new backport branch
git checkout -b fix/foo-stable-17.1

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-17.1

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@AndyScherzinger
Copy link
Member

/backport to stable-17.1

@backportbot-nextcloud
Copy link

The backport to stable-17.1 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-17.1
git pull origin stable-17.1

# Create the new backport branch
git checkout -b fix/foo-stable-17.1

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-17.1

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect when user is talking and send proper data channel messages.
2 participants