style(detekt): Comment on all EmptyFunctionBlock cases

Signed-off-by: Andy Scherzinger <[email protected]>
nextcloud · Dec 4, 2024 · f79feca · f79feca
1 parent e5af4b5
commit f79feca
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/app/src/main/java/com/nextcloud/talk/jobs/LeaveConversationWorker.kt b/app/src/main/java/com/nextcloud/talk/jobs/LeaveConversationWorker.kt
@@ -62,9 +62,11 @@ class LeaveConversationWorker(context: Context, workerParams: WorkerParameters)
                 .observeOn(AndroidSchedulers.mainThread())
                 .subscribe(object : Observer<GenericOverall?> {
                     override fun onSubscribe(d: Disposable) {
+                        // unused atm
                     }
 
                     override fun onNext(p0: GenericOverall) {
+                        // unused atm
                     }
 
                     override fun onError(e: Throwable) {

diff --git a/app/src/main/java/com/nextcloud/talk/utils/DisplayUtils.kt b/app/src/main/java/com/nextcloud/talk/utils/DisplayUtils.kt
@@ -197,7 +197,9 @@ object DisplayUtils {
                 .crossfade(true)
                 .transformations(CircleCropTransformation())
                 .target(object : Target {
-                    override fun onStart(placeholder: Drawable?) {}
+                    override fun onStart(placeholder: Drawable?) {
+                        // unused atm
+                    }
                     override fun onError(error: Drawable?) {
                         chip.chipIcon = error
                     }

diff --git a/detekt.yml b/detekt.yml
@@ -1,7 +1,7 @@
 # SPDX-FileCopyrightText: 2017-2024 Nextcloud GmbH and Nextcloud contributors
 # SPDX-License-Identifier: GPL-3.0-or-later
 build:
-  maxIssues: 125
+  maxIssues: 122
   weights:
     # complexity: 2
     # LongParameterList: 1